fix: fix timing function cross-platform bug #14919
Merged
+84
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DerekMaggio
changed the title
sfoster1
requested changes
Apr 16, 2024
|
|
||
| P = ParamSpec("P") | ||
| R = TypeVar("R") | ||
|
|
||
|
|
||
| def _get_timing_function() -> Callable[[], int]: |
There was a problem hiding this comment.
let's refactor this so that it only does the logic check once at import time rather than every time it's called
Carlos-fernandez
pushed a commit
that referenced
this pull request
May 20, 2024
# Overview Closes https://opentrons.atlassian.net/browse/EXEC-406 Use a timing function universal to Windows, Mac, and Linux when running on Windows and Mac This will allow performance metrics tests to run locally for devs The production implementation will always use Linux # Test Plan - Create test that patches _get_timing_function to return universal timing function and make sure that works - Realized I missed timing synchronous functions so I added that too # Changelog - In robot_context_tracker.py create a _get_timing_function which imports the correct package based on os # Review requests None # Risk assessment low
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Closes https://opentrons.atlassian.net/browse/EXEC-406
Use a timing function universal to Windows, Mac, and Linux when running on Windows and Mac
This will allow performance metrics tests to run locally for devs
The production implementation will always use Linux
Test Plan
Changelog
Review requests
None
Risk assessment
low